Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Add zh_CN PhoneNumber TestCase & TollFreePhoneNumber API & E164PhoneN… #2054

Closed
wants to merge 3 commits into from
Closed

Add zh_CN PhoneNumber TestCase & TollFreePhoneNumber API & E164PhoneN… #2054

wants to merge 3 commits into from

Conversation

Guxinpei
Copy link

done #2053
If you reject me, please tell me how to do it in rightway, cause I'm a rookie, THX!

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2020

Codecov Report

Merging #2054 into master will decrease coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2054      +/-   ##
============================================
- Coverage     56.56%   56.37%   -0.20%     
- Complexity     2068     2070       +2     
============================================
  Files           306      306              
  Lines          4849     4855       +6     
============================================
- Hits           2743     2737       -6     
- Misses         2106     2118      +12     
Impacted Files Coverage Δ Complexity Δ
src/Faker/Provider/zh_CN/PhoneNumber.php 100.00% <100.00%> (ø) 3.00 <2.00> (+2.00)
src/Faker/Provider/ne_NP/Person.php 0.00% <0.00%> (-50.00%) 2.00% <0.00%> (ø%)
src/Faker/Provider/id_ID/Company.php 50.00% <0.00%> (-50.00%) 2.00% <0.00%> (ø%)
src/Faker/Provider/en_UG/Person.php 40.00% <0.00%> (-40.00%) 5.00% <0.00%> (ø%)
src/Faker/Provider/hu_HU/Person.php 40.00% <0.00%> (-40.00%) 5.00% <0.00%> (ø%)
src/Faker/Provider/en_SG/Address.php 66.66% <0.00%> (-33.34%) 6.00% <0.00%> (ø%)
src/Faker/Provider/ka_GE/Address.php 57.14% <0.00%> (-28.58%) 7.00% <0.00%> (ø%)
src/Faker/Provider/uk_UA/Company.php 28.57% <0.00%> (-28.58%) 3.00% <0.00%> (ø%)
src/Faker/Provider/es_ES/Person.php 75.00% <0.00%> (-25.00%) 3.00% <0.00%> (ø%)
src/Faker/Provider/vi_VN/Person.php 40.00% <0.00%> (-20.00%) 5.00% <0.00%> (ø%)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5337ce5...8e3961a. Read the comment docs.

@Guxinpei
Copy link
Author

I can't understand why test coverage is down , the file I commit allready coverage 100% o(╥﹏╥)o

@Guxinpei Guxinpei closed this by deleting the head repository Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants