Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Typo in function's name #2031

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

carlos-mora
Copy link

There is a typo in the functions's name, it should be tollFreePhoneNumber instead of tollFreeNumber

There is a typo in the functions's name, it should be tollFreePhoneNumber instead of tollFreeNumber
@pimjansen
Copy link
Contributor

This will be a breaking change!

@carlos-mora
Copy link
Author

carlos-mora commented Oct 23, 2020

@pimjansen The breaking change was to accept the spanish module with a bad named function. The interface spects the function to be called tollFreePhoneNumber instead of tollFreeNumber, so in the current state the spanish language is broken.
Try it yourself: Use tollFreePhoneNumber in your current language, be sure it works fine, then change to es_ES language.
Are you the reviewer to accept the push?
An alternative is to duplicate the function with the right name an keep the old bad_named function, but i think the right answer it to set the function name to the spected one.

@carlos-mora
Copy link
Author

According to the docs,
imagen
So the function should keep the name accross languages.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants