This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
added protected method Generator::findFormatter #2013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds a protected method
Generator::findFormatter
that can get a formatter without use of cache.The reason I propose it is that we need to define custom way to find a formatter by overiding
Generator::getFormater
but we cannot do it efficiently as the method makes use of cache internally. We would like to be able to keep the native cache feature of the method and just overide the way the formatter callable is found.In other words with this change then we will be able to overide the method
findFormatter
without messing with the cache implementationThanks