Fix U.S. Area Code Generation (Fixes #1837)

[hackel]

Ensures phone numbers generated are valid.

Regular expressions extracted from the PHP port of Google's libphonenumber via the PHP port:
https://github.com/giggsey/libphonenumber-for-php/blob/f3a55dcb6fead9d4fb291c6dadda0564e5ae8d3f/src/data/PhoneNumberMetadata_US.php#L29

[hackel]

It doesn't look like the ImageTest is failing because of me: getimagesize(): Read error!

[pimjansen]

It doesn't look like the ImageTest is failing because of me: getimagesize(): Read error!

Correct, fix for this is already pushed in a PR for the 1.9.0 release.

This fix will solve #1837

[pimjansen]

Could we maybe add some tests?

[hackel]

Yeah, I wasn't sure on the best approach for testing this beyond what is already there. I could check the output against the full regex, or I could pull in libphonenumber-php as a dev dependency and check it against that.

Actually that way we could easily test all of the different locales, though I suspect that could trigger even more failures. Specifically, CA and other +1 countries should use similar logic to this.

[pimjansen]

Yeah, I wasn't sure on the best approach for testing this beyond what is already there. I could check the output against the full regex, or I could pull in libphonenumber-php as a dev dependency and check it against that.

Actually that way we could easily test all of the different locales, though I suspect that could trigger even more failures. Specifically, CA and other +1 countries should use similar logic to this.

Well we clearly have an issue with the 96 one which should not be there. So we can test that one right? Or even all the formats that can match

[shawnlindstrom]

Please see #1792 which I submitted a while ago. It fixes #1837. I just rebased and tests are passing.