Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tcp-example): clean up the TCP example #522

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ROMemories
Copy link
Collaborator

@ROMemories ROMemories commented Nov 13, 2024

Description

As part of #410, and similarly to #521, this PR:

  • renames the embassy-tcp-echo example to tcp-echo, as agreed
  • leverages riot_rs::reexports
  • contains other minor cleanups.

Issues/PRs references

Depends on #521.
Depends on #525.

Open Questions

Change checklist

  • I have cleaned up my commit history and squashed fixup commits.
  • I have followed the Coding Conventions.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.

@ROMemories ROMemories added docs Improvements or additions to documentation network labels Nov 13, 2024
@ROMemories ROMemories mentioned this pull request Nov 13, 2024
34 tasks
@@ -5,7 +5,6 @@
This directory contains example applications that showcase how to use RIOT-rs.

- [benchmark/](./benchmark): how to use `benchmark()`
- [embassy-net-udp/](./embassy-net-udp): UDP echo example
- [embassy-net-tcp/](./embassy-net-tcp): TCP echo example
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TCP example should also be renamed here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants