Support newer Docker API versions by ignoring additional properties in API responses #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n API responses Recently Docker 19.03 was released and it introduced the new 1.40 API version with whole lot of new fields[1], which cause Bollard to fail due to it's use of deny_unknown_fields serde attribute. Quote from the Docker Engine API reference[2]: >The API uses an open schema model, which means server may add extra properties >to responses. >Likewise, the server will ignore any extra query parameters and request body >properties. >When you write clients, you need to ignore additional properties in responses >to ensure they do not break when talking to newer daemons. [1]: https://docs.docker.com/engine/api/version-history/#v140-api-changes [2]: https://docs.docker.com/engine/api/v1.39/#section/Versioning
|
Yes, you're right that the API introduces new fields breaking the old API. However, I previously believed that API pegging was sufficient to maintain API compliance - can you give a minimal example or an error log using |
|
extern crate bollard;
extern crate env_logger;
extern crate tokio;
use bollard::container::InspectContainerOptions;
use bollard::Docker;
use std::env;
use tokio::runtime::current_thread::Runtime;
fn main() {
env_logger::init();
let args: Vec<String> = env::args().collect();
let docker = Docker::connect_with_unix_defaults().unwrap();
let mut rt = Runtime::new().unwrap();
let future = docker.inspect_container(&args[1], None::<InspectContainerOptions>);
rt.block_on(future).unwrap();
} |
|
Adopted in #25 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently Docker 19.03 was released and it introduced the new 1.40 API version with whole lot of new fields, which cause Bollard to fail due to it's use of deny_unknown_fields serde attribute.
Quote from the Docker Engine API reference: