Update to v1.0.9 #335
Open
Update to v1.0.9 #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine suggested changes to take account of issues with the original jquery-ui-touch-punch.js which has not been updated since 2014 - https://github.com/furf/jquery-ui-touch-punch
Lines dealing with "fix for zoomed devices while dragging" prevented jQuery ui sortable from moving items after you drag them to a new position
This fixes the issue: furf#315 where the Apple Pencil triggers a touchmove event and you may struggle to trigger a click with the pencil
Update for Apple Pencil
Previous release had an issue where clicking through to an input or a button (for example the close button on jQuery.ui dialog boxes) was not being recognised as a click. Incorporated another fix from the v0.2.3 branch so the code now treats anything as a click if (a) they leave theri finger on the control for less than 500ms, or (b) they do not move their finger more than 10 pixels
Rwap patch 1
Prevent simulation of two clicks when interaction hasn't moved
Changed .bind and .unbind to .on and .off (works with jQuery v1.7 also)
Firefox on Lenova touch screen (and similar devices) was still failing the $.support.touch test.
Updated comments and header
Minified version was the original and never updated - so has been removed from this fork
Change to ensure that startedMove and startPos are always reset on a touchstart, and touchMoved is reset after a touchEnd.
Fix draggable during mobile scrolling
Added check for MS Surface device support
package.json is needed to register the package on npmjs.com. Adresses #23
Added package.json
In the AMD definition the 'jquery.ui' dependency is invalid. Building a project with webpack results in this error: > ERROR Failed to compile with 1 errors > > This dependency was not found: > > * jquery.ui in ./node_modules/@rwap/jquery-ui-touch-punch/jquery.ui.touch-punch.js Using 'jquery-ui' fixes that.
Defining jquery-ui as dependency instead of jquery.ui
Remove bower.json dependency on original touch-punch
Where the pointer is over an input or text area field, the user was unable to click on that field to enter data. Code added to ignore this.
Ignore where pointer is over an input or textarea
Thanks to @nitrotap - some minor improvements to the code
Original touch punch website no longer available.
Changed the initMouseEvent() to use MouseEvent() method instead,.
Change to .bind and .unbind functionality
Replace deprecated $.fn.bind/unbind
Updated version number to v1.1.2
Update version number on package
* dblclick support
Send dblclick if there are two touches in less than 400ms
* MouseEvent repalces createEvent('MouseEvents')
* Remove MouseEvent initialization
Incorporates pull request which corrects use of MouseEvent creation and supports emulation of double click event on a mouse
Horizontal scrolling within an overflow-x: scroll container wasn't working on mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various updates as suggested / requested to the new RWAP/jquery-ui-touch-punch master.