FIX: Link() methods referred to in SinglePost.ss now return an actual links #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2-update Update for Framework 3.2
Also some suggested improvements to the before_script
Forward port of 0.7 fixes up to master (3.2 compatible branch)
…fix-32 Updated travis to test against 3.2 core
There will also likely be more minor point releases before SilverStripe 3.2 core comes out so removing this makes it easier.
…nt-fix FIX augmentSQL func to be compatible with 3.2 method signature
…ates Template fixes
…andard-code-of-conduct Added standard code of conduct
…andard-git-attributes Added standard git attributes
…andard-license Added standard license
…andard-editor-config Added standard editor config
…andard-travis-config Added standard Travis config
…andard-scrutinizer-config Added standard Scrutinizer config
…t-to-psr-2 Converted to PSR-2
…-license-year Updated license year
… link. Fixed templates accordinly
gordonbanderson
force-pushed
the
14-links
branch
from
963c803 to
6333a5f
Compare
Contributor
|
@gordonbanderson because this will introduce a breaking change, we'll have to look at releasing a major version once I get master into a good state. Definitely keen to include this though :D |
Contributor
|
@gordonbanderson master has been refreshed with 0.8, you'll want to rebase your work (or check if we haven't already fixed in 0.8). Thanks for your patience on this :) |
Contributor
|
Please rebase. |
Contributor
Author
|
Replaced by PR #189 |
Contributor
Author
|
I note @camfindlay that the installation docs recommend the use of master... https://github.com/silverstripe/silverstripe-forum/blob/master/docs/en/Installation.md So there may be a few more broken forums out there than you hope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed hardcoded links that SinglePost.ss uses, fixed templates accordingly