Add Custom Crop ViewController #113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Excellent. Very nice, thank you for the contribution. Has anybody else reviewed this yet? |
Author
|
No news on this? Ill might just create a new pod with this functionality based on yours. Is it ok @fulldecent ? |
Owner
|
That is okay but also I am happy to merge here. Would you please be able to attach a few screenshots illustrating the new feature? Sorry, I know Travis can be a pain, I hope that will sort itself out. |
Owner
|
Finally killed Travis and moved to GitHub Actions. Testing now passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable for custom aspect ratio when cropping.
Can't make tests pass on Travis though, due to the error message:
“Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.
I believe this is an error on xcbuild or something must be outdated on Travis CI server side. Also, didn't check the .travis.yml, something might be wrong there.