Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Show story ID in story edit form and hover #219

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

marnen
Copy link
Contributor

@marnen marnen commented Mar 2, 2014

This displays the story ID in the edit form and hover balloon (see #204). Note that this pull request currently has a problem: spec/features/stories_spec.rb:64 passes if run by itself, but fails if any other specs are run with it. I'd appreciate suggestions on how to resolve this, because I've tried everything I can think of. (I suspect that part of the problem is the way Capybara interacts with Firefox, so perhaps I'll try running it headless with capybara-webkit and see if that works.)

This simple addition was surprisingly hard to make. Impediments I noticed:

  • It was surprisingly hard to change the HTML in the edit form, because it's all generated programmatically in story_view.js. It should probably be rendered in an ERb or EJS template instead, like the hover text.
  • Likewise, because the hover text is in an EJS template, I basically needed to make the same change twice in two different ways. I suspect moving the edit form into EJS would help reduce duplication.
  • The "feature specs" that we have really aren't feature specs—that is, there's little in the way of automated tests that actually specify the application's UI. I'd like to write some Cucumber stories to fix that.

@marnen
Copy link
Contributor Author

marnen commented Mar 2, 2014

Some eye candy:
image
image

@marnen
Copy link
Contributor Author

marnen commented Mar 17, 2014

I notice that the build failed. With this and #220, I've been having some specs fail erratically for no obvious reason. They pass when they're run by themselves. What do you want to do about this?

@@ -79,6 +79,7 @@ en:
iteration_length: 'Iteration length'
default_velocity: 'Default velocity'
story:
id: 'ID'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marnen suggest to use # instead of ID

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been ages since I did this, but I assume I did this because I was basically copying Pivotal Tracker's terminology. Also, "ID" can stand alone as a word, whereas "#" can't. Looking at the UI again, though, perhaps "#6" would work well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants