This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 350
Show story ID in story edit form and hover #219
Open
marnen
wants to merge
12
commits into
fulcrum-agile:master
Choose a base branch
from
marnen:show-story-id
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject explicitly before we use it. [fulcrum-agile#204]
I notice that the build failed. With this and #220, I've been having some specs fail erratically for no obvious reason. They pass when they're run by themselves. What do you want to do about this? |
@@ -79,6 +79,7 @@ en: | |||
iteration_length: 'Iteration length' | |||
default_velocity: 'Default velocity' | |||
story: | |||
id: 'ID' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marnen suggest to use #
instead of ID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been ages since I did this, but I assume I did this because I was basically copying Pivotal Tracker's terminology. Also, "ID" can stand alone as a word, whereas "#" can't. Looking at the UI again, though, perhaps "#6" would work well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This displays the story ID in the edit form and hover balloon (see #204). Note that this pull request currently has a problem:
spec/features/stories_spec.rb:64
passes if run by itself, but fails if any other specs are run with it. I'd appreciate suggestions on how to resolve this, because I've tried everything I can think of. (I suspect that part of the problem is the way Capybara interacts with Firefox, so perhaps I'll try running it headless with capybara-webkit and see if that works.)This simple addition was surprisingly hard to make. Impediments I noticed:
story_view.js
. It should probably be rendered in an ERb or EJS template instead, like the hover text.