Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported hashing methods. #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jomunoz
Copy link
Contributor

@jomunoz jomunoz commented Oct 11, 2017

Support of Whirlpool and RIPEMD160 hashing methods was removed in
cryptography.hazmat.primitives.
pyca/cryptography@0d6aaf4

Support of Whirlpool and RIPEMD160 hashing methods was removed in
cryptography.hazmat.primitives.
pyca/cryptography@0d6aaf4
This was referenced Oct 11, 2017
@wayne-luminal
Copy link
Contributor

Thanks @jomunoz! I merged and released #174 to get credstash usable again. I'll look at pulling your changes in.

@jomunoz
Copy link
Contributor Author

jomunoz commented Oct 12, 2017

Thanks @wayne-luminal, I think this pr might be the proper solution. In the other solution, by locking to a particular version of the cryptography library, we will be missing bugs fixes that will be made for that library.

@wayne-luminal
Copy link
Contributor

@jomunoz You're right. When I looked at both PRs, I see this one is failing but haven't had time to dig into what the issue is yet. I figured to get a workable credstash again I'd add temporarily add the <2.1 to cryptography.

@tomgoren
Copy link
Contributor

I guess I duped this without noticing #178 :(

There are some additional bits in my PR that I think might be important.

@ramonamis
Copy link

hello! is there any chance this can get released? pinning down the crypto library is not a permanent solution as it breaks other ssl libraries.

@tomgoren
Copy link
Contributor

@ramonamis see #178 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants