Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relative to other tests 'run' mark 'after' and 'before' kwargs #67

Closed
wants to merge 5 commits into from

Conversation

mondeja
Copy link

@mondeja mondeja commented Jul 22, 2020

Closes #65

As was reported, relative to other tests module ordering is not working because is not implemented.

Copy link

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually prepared a PR for the same feature, but had trouble to get it running in the CI (a compatibility issue with pytest-cov) - so you beat me to it :)
It would also make sense to update the documentation (docs/index.rst) to move the related part out of the "Aspirational" chapter.

Copy link

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!
@ftobia - the Travis builds are currently failing due to an incompatibility with the latest version of pytest-cov - I'm looking into this. But they are also not visible on the PR; I had a similar issue recently, still unresolved - maybe you can check the stettings.

pytest_ordering/__init__.py Outdated Show resolved Hide resolved
pytest_ordering/__init__.py Show resolved Hide resolved
@mrbean-bremen
Copy link

@mondeja - I didn't notice at the time, but there is already a PR (#37) that implements this. I integrated that in my fork (I was checking the oldest PRs first), so yours didn't get integrated, although I had planned to do so first...

@mondeja
Copy link
Author

mondeja commented Nov 4, 2020

so yours didn't get integrated, although I had planned to do so first...

Don't worry about that.

@mondeja mondeja closed this Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The module relative order don't working???
2 participants