Add support for --indulgent-ordering option
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyg0808
force-pushed
the
run-before-failedfirst
branch
from
bfbb2b6 to
2b39ffa
Compare
This requests that the plugin be run first, allowing other plugins to override its ordering. This is useful if the order requirements provided by this plugin are intended to be priorities, rather than absolute requirements. For example, if some test cases run slower than others in your test suite, you can mark them as desirable to run first when running tests in parallel, allowing a more efficient use of a multi-core processor. By adding the `--indulgent-ordering` option, this ordering can still be overridden by, for example, the `--failed-first` option, which prioritizes tests which failed during the last run. Without `--indulgent-ordering`, the `--failed-first` option will be overridden by pytest-ordering, reducing its usefulness by increasing the total time until the results are available.
andyg0808
force-pushed
the
run-before-failedfirst
branch
from
8315fb7 to
04d8b2e
Compare
ftobia
reviewed
Jan 23, 2019
|
Thanks for the review! The changes are made. |
|
Sorry I let this go so long. I'll merge soon and hopefully do a release this weekend. |
|
@andyg0808 - FWIW, I integrated your PR into my fork, though I couldn't get it merged cleanly, so I did it manually. Same for your xdist test in PR #52. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requests that the plugin be run first, allowing other plugins to
override its ordering. This is useful if the order requirements
provided by this plugin are intended to be priorities, rather than
absolute requirements. For example, if some test cases run slower than
others in your test suite, you can mark them as desirable to run first
when running tests in parallel, allowing a more efficient use of a
multi-core processor. By adding the
--indulgent-orderingoption,this ordering can still be overridden by, for example, the
--failed-firstoption, which prioritizes tests which failed duringthe last run. Without
--indulgent-ordering, the--failed-firstoption will be overridden by pytest-ordering, reducing its usefulness
by increasing the total time until the results are available.