Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing/server] return container labels when listing containers #1031

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

taraspos
Copy link
Contributor

Testing server behavior is currently different from the actual server when listing containers.

When listing containers on a testing server labels map is always nil and the additional call is needed to inspectContainer, however, this is not the case on the actual docker server.

This PR sets labels for the listed container to fix that.

@fsouza
Copy link
Owner

fsouza commented Feb 7, 2024

Thanks for contributing!

@fsouza fsouza merged commit 2359f27 into fsouza:main Feb 7, 2024
23 checks passed
@taraspos taraspos deleted the patch-1 branch February 18, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants