update-to-react-17 #117
Closed
update-to-react-17 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#80
Issues
Many people are having issues with react-sortable-tree after upgrading to React 17. It looks like the cause is using findDOMNode and mismatched React versions due to a peer dependency issue. This PR should resolve the issues.
facebook/react#20131 (comment)
frontend-collective/react-sortable-tree#821
frontend-collective/react-sortable-tree#450
frontend-collective/react-sortable-tree#281 (comment)
#70
Test steps
yarn
yarn build
in the react-sortable-tree repo
yarn add file:$PATH_TO_THIS_REPO/lib
add in some yarn resolutions in package.json so storybook will use React 17
"resolutions": {
"react": "^17.0.1",
"react-dom": "^17.0.1"
}
yarn storybook
test around make sure nothing is broken