site: set fallback version #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a fallback version, which is applied in case the site is built without tags fetched. This ensures the version string is not empty. The fallback-version is set when branching a release off. It is et to the minor-version only. The patch version is omitted, like it is currently done for testing images. Signed-off-by: David Bauer <[email protected]>
|
I think comparing and choosing the higher number could be useful. One might encounter a repo where some tags are present (for example those at the time of the fork) but not all. But as long as it's not empty the rest doesn't matter too much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a fallback version, which is applied in case the site is built without tags fetched. This ensures the version string is not empty.
The fallback-version is set when branching a release off. It is et to the minor-version only. The patch version is omitted, like it is currently done for testing images.