Init location "FBLipke" and device "nsm2_xw"

.github/checks/check-duplicates.sh

@@ -0,0 +1,81 @@
+#!/bin/bash
+
+# Locations pattern
+location_files="locations/*.yml"
+
+# Initialize a variable to track if any errors are found
+error_found=0
+
+# Function to check for duplicates
+check_duplicates() {
+  local yq_query="$1"
+  local description="$2"
+  local file_pattern="$3"
+
+  # Expand the file pattern to a list of files
+  # shellcheck disable=SC2206
+  files=($file_pattern)
+
+  # Check if any files match the pattern
+  if [ ${#files[@]} -eq 0 ]; then
+    echo "No files matching pattern $file_pattern"
+    return
+  fi
+
+  # Run the yq command with the expanded list of files
+  duplicates=$(yq "$yq_query" "${files[@]}" | grep -v -- '---' | tr '[:upper:]' '[:lower:]' | sed 's/["'\'']//g' | sort | uniq -cd)
+  if [ -n "$duplicates" ]; then
+    echo "Duplicate $description found:"
+    echo "$duplicates"
+    error_found=1
+  fi
+}
+
+# Check for duplicates accross all locations
+echo "Checking $location_files"
+
+# Check for hostname duplicates within hosts
+check_duplicates 'select(.hosts != null) | .hosts[].hostname' "hostnames within hosts" "$location_files"
+
+# Check for mac_override duplicates within hosts
+check_duplicates 'select(.hosts != null) | .hosts[].mac_override | select(. != null) | to_entries[] | .value' "mac_overrides within hosts" "$location_files"
+
+# Check for hostname duplicates within snmp_devices
+check_duplicates 'select(.snmp_devices != null) | .snmp_devices[].hostname' "hostnames within snmp_devices" "$location_files"
+
+# Check for address duplicates within snmp_devices
+check_duplicates 'select(.snmp_devices != null) | .snmp_devices[].address' "addresses within snmp_devices" "$location_files"
+
+# Check for ipv6_prefix duplicates
+check_duplicates 'select(.ipv6_prefix != null) | .ipv6_prefix' "ipv6_prefixes" "$location_files"
+
+# Check for ipv4_prefix duplicates within networks
+check_duplicates 'select(.networks != null) | .networks[] | select(.prefix != null) | .prefix' "prefix within networks" "$location_files"
+
+# Check for duplicate hosts within 11a channel assignments
+check_duplicates 'select(.location__channel_assignments_11a_standard__to_merge != null) | .location__channel_assignments_11a_standard__to_merge | keys[]' "hosts within 11a channel assignments" "$location_files"
+
+# Check for duplicate hosts within 11g channel assignments
+check_duplicates 'select(.location__channel_assignments_11g_standard__to_merge != null) | .location__channel_assignments_11g_standard__to_merge | keys[]' "hosts within 11g channel assignments" "$location_files"
+
+# Check for duplicates within a single location
+for file in $location_files; do
+  echo "Checking $file"
+
+  # Check for VID duplicates within networks
+  check_duplicates 'select(.networks != null) | .networks[] | select(.vid != null) | .vid' "VID within networks" "$file"
+
+  # Check for name duplicates within networks
+  check_duplicates 'select(.networks != null) | .networks[] | select(.name != null) | .name' "name within networks" "$file"
+
+  # Check for ipv6_subprefix duplicates within networks
+  check_duplicates 'select(.networks != null) | .networks[] | select(.ipv6_subprefix != null) | .ipv6_subprefix' "ipv6_subprefix within networks" "$file"
+
+done
+
+# Exit with a non-zero status code if any errors were found
+if [ "$error_found" -eq 1 ]; then
+  exit 1
+else
+  echo "No duplicates found"
+fi

.github/checks/check-interface-names.sh

@@ -0,0 +1,47 @@
+#!/bin/bash
+
+# Locations pattern
+location_files="locations/*.yml"
+
+# Initialize a variable to track if any errors are found
+error_found=0
+
+# Function to check for errors in interface names
+check() {
+  local yq_query="$1"
+  local file_pattern="$2"
+
+  # Expand the file pattern to a list of files
+  # shellcheck disable=SC2206
+  files=($file_pattern)
+
+  # Check if any files match the pattern
+  if [ ${#files[@]} -eq 0 ]; then
+    echo "No files matching pattern $file_pattern"
+    return
+  fi
+
+  # Run the yq command with the expanded list of files
+  ifnames=$(yq "$yq_query" "${files[@]}" | grep -v -- '---' | sed 's/["'\'']//g' | sort | uniq)
+
+  # Iterate over each interface name and check if it matches the allowed pattern
+  for ifname in $ifnames; do
+    if [[ ! "$ifname" =~ ^[a-z0-9_]+$ ]]; then
+      echo "Error: Interface name does not match allowed pattern [0-9a-z_]: $ifname"
+      error_found=1
+    fi
+  done
+}
+
+# Check for issues across locations
+echo "Checking $location_files"
+
+# Check for interface name issues
+check 'select(.networks != null) | .networks[] | select(.name != null) | .name' "$location_files"
+
+# Exit with a non-zero status code if any errors were found
+if [ "$error_found" -eq 1 ]; then
+  exit 1
+else
+  echo "No errors found"
+fi

.github/checks/check-mac-override-missing.sh

@@ -0,0 +1,79 @@
+#!/bin/bash
+
+# Initialize a variable to track if any errors are found
+error_found=0
+
+# Define patterns for model files
+model_files='group_vars/model_*.yml'
+
+# If location files are passed as arguments, override the default location_files variable
+if [ "$#" -gt 0 ]; then
+  # Treat location_files as an array to handle multiple arguments
+  location_files=("$@")
+else
+  # Use the default pattern if no arguments are passed
+  location_files=(locations/*.yml)
+fi
+
+# If location files are passed as arguments, override the location_files variable
+if [ "$#" -gt 0 ]; then
+  location_files=("$@")
+fi
+
+# Find all models that require a mac_override
+declare -A mac_override_required_models
+
+for model_file_path in $model_files; do
+  # Extract model name from file path
+  model_file=$(basename "$model_file_path" .yml)
+  model_name=${model_file#model_}
+
+  # Check if the model requires mac_override
+  requires_mac_override=$(yq '.requires_mac_override' "$model_file_path" | tr -d '"')
+
+  # Store the result in the associative array
+  mac_override_required_models["$model_name"]=$requires_mac_override
+done
+
+# Find all missing mac_overrides in the provided or all location files
+for location_file in "${location_files[@]}"; do
+  # Check if the file exists (in case only some files were passed in GitHub Action)
+  if [ ! -f "$location_file" ]; then
+    echo "File $location_file does not exist, skipping."
+    continue
+  fi
+
+  # Get hosts as a single YAML block to minimize calls to yq
+  hosts=$(yq '.hosts' "$location_file")
+
+  # Loop through each host entry
+  for i in $(seq 0 $(($(echo "$hosts" | yq '. | length') - 1))); do
+    hostname=$(echo "$hosts" | yq ".[$i].hostname" | tr -d '"')
+    model=$(echo "$hosts" | yq ".[$i].model" | tr -d '"')
+    mac_override=$(echo "$hosts" | yq ".[$i].mac_override" | tr -d '"')
+
+    # Convert model name to match the model file format (underscore instead of hyphen)
+    model_name=${model//-/_}
+
+    # Check if the model requires mac_override using the associative array
+    requires_mac_override=${mac_override_required_models["$model_name"]}
+
+    if [ "$requires_mac_override" = "true" ]; then
+      if [ "$mac_override" == "null" ]; then
+        # Output the missing mac_override details immediately
+        echo "Host $hostname (model: $model) in $location_file is missing mac_override."
+        error_found=1
+      fi
+    fi
+  done
+done
+
+# Exit with a non-zero status code if any errors were found
+if [ "$error_found" -eq 1 ]; then
+  echo "Please look at the model files of the devices missing a mac_override for documentation"
+  echo "about how to read the mac_address from the device."
+  exit 1
+else
+  echo "No MAC override issues found."
+fi
+

.github/workflows/check-address-duplicates.yml → .github/workflows/check-duplicates.yml

@@ -1,17 +1,18 @@
 ---
-name: Check for duplicate addresses
+name: Check for duplicates
 
 on: [push, pull_request]  # yamllint disable-line rule:truthy
 
 jobs:
-  check-address-duplicates:
+  check-duplicates:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
-      - name: Run address duplicate check
+      - name: Run check for duplicates
         run: |
-          ./.github/checks/check-address-duplicates.sh
+          yq --version
+          ./.github/checks/check-duplicates.sh

.github/workflows/check-interface-names.yml

@@ -0,0 +1,33 @@
+---
+name: Check interface names
+
+on: [push, pull_request]  # yamllint disable-line rule:truthy
+
+jobs:
+  check-interface-names:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout branch
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      # Get a list of changed files and pass them to the script
+      - name: Get Changed Files and Run interface name check
+        run: |
+          # Fetch previous commits for comparison
+          git fetch origin main
+
+          # Get list of changed files compared to main branch
+          changed_files=$(git diff --name-only origin/main)
+
+          # Filter out only the location files from the list of changed files
+          location_files=$(echo "$changed_files" | grep -E '^locations/.*\.yml$' || true)
+
+          if [ -z "$location_files" ]; then
+            echo "No location files changed, skipping check."
+            exit 0
+          fi
+
+          # Run the interface name check script with the filtered location files
+          ./.github/checks/check-interface-names.sh "$location_files"