Skip to content

Conversation

@crienzo
Copy link
Member

@crienzo crienzo commented Aug 4, 2020

No description provided.

root and others added 30 commits February 11, 2020 10:05
…them, shane: need to fix swig.i so the stuff I changed to by hand works when generated
@crienzo crienzo requested a review from Astaelan August 4, 2020 22:22
/Loader/.vs/Loader/v16/Server/sqlite3
/.vs/Managed/v16
/Loader/.vs/Loader/DesignTimeBuild/.dtbcache
*.dtbcache
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce all this to just:
.vs

@Astaelan
Copy link
Collaborator

Astaelan commented Aug 4, 2020

Remove intermediate binary file @ .vs/Managed/DesignTimeBuild/.dtbcache.v2

<ItemGroup>
<FrameworkReference Include="Microsoft.AspNetCore.App" />
</ItemGroup>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the ASP reference necessary or left over from testing?

<PropertyGroup>
<ShowAllFiles>true</ShowAllFiles>
</PropertyGroup>
</Project> No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file, .user files should be local only.

{
public interface IPluginDispatcher
{
bool Onload();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to: OnLoad?


string DispatchXMLCallback(string section, string tag, string key, string value, Event evt);

IEnumerable<string> GetApiNames();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to GetAPINames for consistency.

public SWIGTYPE_p_switch_event_t(global::System.IntPtr cPtr, bool futureUse) {
swigCPtr = new global::System.Runtime.InteropServices.HandleRef(this, cPtr);
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes in this file appear to be made in this file, as this is generated by swig, we need to alter the swig.i to make these public upon regeneration.
I'm not exactly sure the correct format for the swig.i because this is for constructors, will have to look into this.
An example exists in the swig.i for a normal method, it should look a little something like this, with the obvious changes:
%csmethodmodifiers CoreSession::originate "protected";

}

public static NativeCallbacks i_callbacks;

Copy link
Collaborator

@Astaelan Astaelan May 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add:
public static NativeAPICallback APICallback = null;
etc for each of the 3.

Loader/Loader.cs Outdated

// Return the marshalled callbacks for the native interfaces
return new NativeCallbacks
i_callbacks = new NativeCallbacks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add:
APICallback = new NativeAPICallback(NativeAPIHandler);
etc for the 3

Loader/Loader.cs Outdated
return new NativeCallbacks
i_callbacks = new NativeCallbacks
{
NativeAPICallback = Marshal.GetFunctionPointerForDelegate<NativeAPICallback>(NativeAPIHandler),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to:
NativeAPICallback = Marshal.GetFunctionPointerForDelegate(APICallback);
etc for the 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants