Skip to content

Conversation

@akirpa
Copy link

@akirpa akirpa commented Mar 12, 2017

Perform 'make test' after build package

akirpa added 3 commits March 12, 2017 04:45
Using new flag provide execute 'make test' after 'make build'
Determine of new variable for -T option
Describe function for new -T common flag
@stesser
Copy link
Member

stesser commented Apr 22, 2022

Sorry for the late reply - I have been the maintainer of the FreeBSD port for a long time, but did not have access to this Github repository.
Anyway, the pull request is incomplete, since it does not take the TEST_DEPENDS into account.
There is partial/incomplete support for the fetching of test dependencies, and they would need to be added to the build dependencies if the -T option has been given. (Normally, test dependencies should be built just before the tests are performed, not before the build starts, since the test dependencies might in some way depend on the port that is to be tested being available - this would require significant further changes to get right.)
I might add the required code to include these test dependencies, but I'm not convinced that adding them to the build dependencies does not lead to build errors or dependency loops for some ports ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants