dma-buf: Zero out stat struct in dma_buf_stat #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obiwac
force-pushed
the
bugfix/zero-out-sb
branch
from
fc047c2 to
ceb7d3e
Compare
Member
|
Makes sense. Let's use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kern_fstat, which ends up callingdma_buf_statdoes not zero this for us (see D54556). This causes issues because obviously we're leaking kernel stack to the userspace, but also because thest_inofield contains garbage.The wlroots Vulkan renderer relies on checking inos of all the planes of a DMA-BUF to know if it is disjointed or not, (see
render/vulkan/texture.c:is_dmabuf_disjoint). This caused very transient issues, where sometimes these inos happened to not match up.I don't yet know how Linux sets the inos on DMA-BUF planes, but in fine we will want to emulate that behaviour. This fixes things for now though as now all inos are 0 so they will never be seen as disjointed.