Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add @types/node package #996

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

scissorsneedfoodtoo
Copy link
Contributor

Checklist:

Related to #986

For some reason there's an issue with the @types/node dependency in #986 that results in the Overload signatures must all be optional or required error when type checking is run. Looking at the main TypeScript repo, they use v22.5.4 of the @types/node package, where the line resolve?(specified: string, parent?: string | URL): Promise<string>; in node_modules/@types/node/module.d.ts seems to be causing the issue.

Adding the latest version of the @types/node package here resolves this issue.

We can look into removing this as a dependency later with future TypeScript updates.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 2.2 MB types

View full report↗︎

@scissorsneedfoodtoo scissorsneedfoodtoo marked this pull request as ready for review September 19, 2024 08:08
@scissorsneedfoodtoo scissorsneedfoodtoo requested a review from a team September 20, 2024 07:10
@raisedadead raisedadead merged commit 22866cc into main Sep 20, 2024
18 checks passed
@raisedadead raisedadead deleted the fix/add-node-types-package branch September 20, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants