Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optimzie sidebar ads #1035

Merged
merged 2 commits into from
Oct 24, 2024
Merged

feat: optimzie sidebar ads #1035

merged 2 commits into from
Oct 24, 2024

Conversation

ahmaxed
Copy link
Member

@ahmaxed ahmaxed commented Oct 17, 2024 •
edited by scissorsneedfoodtoo
Loading

⚠️ NOTE: BLOCKED UNTIL FURTHER NOTICE ⚠️

This pr optimizes the number of ads that can fit in the sidebar.

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

@ahmaxed ahmaxed requested a review from a team as a code owner October 17, 2024 12:01
scissorsneedfoodtoo
scissorsneedfoodtoo reviewed Oct 18, 2024
View reviewed changes
src/_includes/assets/css/screen.css Outdated Show resolved Hide resolved
src/_includes/assets/css/screen.css Outdated Show resolved Hide resolved
@ahmaxed ahmaxed added the status: blocked The discussion has not been finalized yet label Oct 21, 2024
@ahmaxed
Copy link
Member Author

ahmaxed commented Oct 21, 2024

Waiting on Quincy's approval of the banner ads before proceeding.

scissorsneedfoodtoo
scissorsneedfoodtoo previously approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@scissorsneedfoodtoo scissorsneedfoodtoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ NOTE: BLOCKED UNTIL FURTHER NOTICE ⚠️

Tested again locally and everything LGTM.

Approving this now so we can merge this freely after Quincy signs off on the banner ads.

@ahmaxed
Copy link
Member Author

ahmaxed commented Oct 22, 2024

Seems like we would need a title 'advertisement' for each ad, so I made some adjustments.
@scissorsneedfoodtoo, I would appreciate it if you could give it another go.

scissorsneedfoodtoo
scissorsneedfoodtoo approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@scissorsneedfoodtoo scissorsneedfoodtoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything LGTM 👍

I like the way that the "ADVERTISEMENT" text is hidden by default now. That's a huge improvement over what we currently have. It also makes sense to show this text above each ad that loads.

@scissorsneedfoodtoo scissorsneedfoodtoo merged commit a90dff2 into main Oct 24, 2024
17 checks passed
@scissorsneedfoodtoo scissorsneedfoodtoo deleted the feat/optimize-sidebar-ads branch October 24, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scissorsneedfoodtoo scissorsneedfoodtoo scissorsneedfoodtoo approved these changes

Assignees
No one assigned
Labels
status: blocked The discussion has not been finalized yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmaxed @scissorsneedfoodtoo