fix(UI): enhancements to the admin dashboard page issue #532 #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored By: Carly Thomas <[email protected]>
Comment on lines
+143
to
+149
| > | ||
| <option value={10}>10</option> | ||
| <option value={20}>20</option> | ||
| <option value={30}>30</option> | ||
| <option value={40}>40</option> | ||
| <option value={50}>50</option> | ||
| </select> |
There was a problem hiding this comment.
is there a reason why this is hardcoded to 50?
Comment on lines
+160
to
+170
| <button | ||
| onClick={() => setPageIndex(0)} | ||
| disabled={!canPreviousPage} | ||
| style={{ | ||
| marginLeft: '10px', | ||
| marginRight: '10px', | ||
| color: '#d1d1d1', | ||
| fontSize: '1.5em' | ||
| }} | ||
| > | ||
| |<b><</b> |
There was a problem hiding this comment.
I see a lot of repeated styling code in the buttons, would we be able to cut down on this?
|
|
||
| const startEntry = pageIndex * entriesPerPage + 1; | ||
| const endEntry = Math.min((pageIndex + 1) * entriesPerPage, rows.length); | ||
| const totalEntries = rows.length; |
There was a problem hiding this comment.
We should leverage this variable for the pagination feature, we should be able to dynamically create the options for the footer, removing the hardcoded options. We can just generate some mock data to fill in the students in a class so that we can simulate the footer still displaying and working correctly? Let me know your thoughts on this.
|
left some comments, let me know if I can clarify any of them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Closes #532
Worked in collaboration with @CarlyAThomas
In relation to post.