feat: Watchers & Misc Fixes #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Since it sometimes used to trigger updateDropTarget after drop event which used leave isDragging: true. This prevented the editor resizer from appearing after the drop. - Also, refactored code a bit to avoid unnecessary DOM updates
This fixes zoom lag in new chrome browser. Apparently, combination of border-radius + box-shadow + css scale change is computationally very heavy for chrome browser (Although, it works well on Firefox and used to work in old chrome browser) Co-authored-by: Suraj Shetty <[email protected]>
… source is an object
- move variableOptions computation to store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watchers on variables
Watcher on an object/array
This one watches
billingItemsarray and computes total qty & pricewatcher.mp4
Watcher on a primitive variable with immediate flag
This one watches
searchText(bound to TextInput) and filters the results and sets it in itemsList variable. Run immediately marked for an eager watcherwatcher-immediate.mp4
Other fixes
canHaveChildren()Added Studio Client Script doctype to decouple scripts from events. Currently they are stored in the blocks JSON itself. But this will take some time so will do it after Build