Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): Suppress creation of err logs for req failures #2433

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

balamurali27
Copy link
Contributor

@balamurali27 balamurali27 commented Jan 20, 2025

This is possible by setting http_status_code to < 500. Using custom
status code 420 for this purpose.

  • Need to figure out way to push whole traceback to sentry before doing this. Seems neither press nor agent does this at this point.

This is possible by setting http_status_code to < 500. Using custom
status code 420 for this purpose.
@balamurali27 balamurali27 force-pushed the suppress-agent-http-req-err-logs branch from 16b4d6c to 4ef2a80 Compare January 20, 2025 13:05
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 38.29%. Comparing base (62f834a) to head (4ef2a80).

Files with missing lines Patch % Lines
press/exceptions.py 60.00% 2 Missing ⚠️
press/agent.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2433   +/-   ##
=======================================
  Coverage   38.28%   38.29%           
=======================================
  Files         378      378           
  Lines       29771    29777    +6     
=======================================
+ Hits        11399    11403    +4     
- Misses      18372    18374    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant