Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RemoteFrappeSite): Make method more robust #2318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cogk
Copy link
Contributor

@cogk cogk commented Nov 29, 2024

What if your site is api-xyz.example.com 😄?

https://api-xyz.example.com/api/method/frappe.ping is not correctly split because /api appears twice

@cogk cogk force-pushed the fix-make-RemoteFrappeSite-more-robust branch from 8473747 to 5ef2381 Compare November 29, 2024 15:49
@cogk cogk force-pushed the fix-make-RemoteFrappeSite-more-robust branch from 5ef2381 to 16eb010 Compare November 29, 2024 15:49
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.19%. Comparing base (58bd325) to head (16eb010).

Files with missing lines Patch % Lines
press/utils/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2318   +/-   ##
=======================================
  Coverage   42.19%   42.19%           
=======================================
  Files         376      376           
  Lines       28695    28695           
=======================================
  Hits        12109    12109           
  Misses      16586    16586           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant