Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(site-db-user): remove instances of old db user manager #2305

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

tanmoysrt
Copy link
Member

@tanmoysrt tanmoysrt commented Nov 25, 2024

  • added archive_site_database_users function to call on site archive or moving to some unsupported site plan

@tanmoysrt tanmoysrt marked this pull request as ready for review November 25, 2024 11:11
@tanmoysrt tanmoysrt merged commit d377ca8 into frappe:master Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.68%. Comparing base (6b2f07f) to head (4d97a3f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
press/press/doctype/site/site.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2305      +/-   ##
==========================================
+ Coverage   39.65%   39.68%   +0.02%     
==========================================
  Files         375      375              
  Lines       28610    28537      -73     
==========================================
- Hits        11345    11324      -21     
+ Misses      17265    17213      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@tanmoysrt tanmoysrt deleted the cleanup_old_database_user_creds branch November 25, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant