fix(release-group-variable): Make value a text field

To add longer keys
frappe · Jan 20, 2025 · 460e652 · 460e652
1 parent 8405200
commit 460e652
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/press/press/doctype/release_group_variable/release_group_variable.json b/press/press/doctype/release_group_variable/release_group_variable.json
@@ -20,7 +20,7 @@
   },
   {
    "fieldname": "value",
-   "fieldtype": "Data",
+   "fieldtype": "Text",
    "in_list_view": 1,
    "label": "Value",
    "reqd": 1
@@ -36,7 +36,7 @@
  "index_web_pages_for_search": 1,
  "istable": 1,
  "links": [],
- "modified": "2024-02-11 14:56:12.851224",
+ "modified": "2025-01-20 15:12:45.664299",
  "modified_by": "Administrator",
  "module": "Press",
  "name": "Release Group Variable",

diff --git a/press/press/doctype/release_group_variable/release_group_variable.py b/press/press/doctype/release_group_variable/release_group_variable.py
@@ -9,7 +9,7 @@ class ReleaseGroupVariable(Document):
 	# begin: auto-generated types
 	# This code is auto-generated. Do not modify anything in this block.
 
-	from typing import TYPE_CHECKING
+	from typing import TYPE_CHECKING, ClassVar
 
 	if TYPE_CHECKING:
 		from frappe.types import DF
@@ -19,16 +19,15 @@ class ReleaseGroupVariable(Document):
 		parent: DF.Data
 		parentfield: DF.Data
 		parenttype: DF.Data
-		value: DF.Data
+		value: DF.Text
 	# end: auto-generated types
 
-	dashboard_fields = ["key", "value"]
+	dashboard_fields: ClassVar = ["key", "value"]
 
 	@staticmethod
 	def get_list_query(query, filters=None, **list_args):
 		environmentVariable = frappe.qb.DocType("Release Group Variable")
 		query = query.where(environmentVariable.internal == 0).orderby(
 			environmentVariable.key, order=frappe.qb.asc
 		)
-		configs = query.run(as_dict=True)
-		return configs
+		return query.run(as_dict=True)