fix: prevent invitation of disabled users with clear validation message #2478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes user invitation issues described in #2473 by adding proper backend validation for disabled users.
Changes Made
helpdesk/api/agent.py
to detect disabled users before creating invitationsProblem Solved
Before: Inviting a disabled user would cause unclear errors or system issues
After: Clear validation message: "User {email} is disabled. Please enable the user first to invite them."
Testing
Related Issues
Addresses part 1 of issue #2473
Type of Change
Additional Notes
This change focuses on the invitation validation issue. The user deletion and password reset issues mentioned in #2473 may require separate PRs for targeted fixes.