fix(material request): mapping Sales Order Item Delivery Date to Mate… #45227
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rial Request Item Required By as mentioned in https://discuss.frappe.io/t/item-delivery-date-on-sales-order-is-not-transferred-to-material-request-item-required-by-date/140479 fixing When you create a Material Request directly on the Sales Order via → Create → Material Request, Delivery Date on Sales Order Item is not transferred to Material Request Item Required By date.
In order to pass the linters test which I find meaningless as it asks for the comma after the last item in a dictionary data type
Linters formatting applied
nabinhait
approved these changes
Jan 24, 2025
nabinhait
added
backport version-15-hotfix
and removed
needs-tests
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
#45227) * fix(material request): mapping Sales Order Item Delivery Date to Material Request Item Required By as mentioned in https://discuss.frappe.io/t/item-delivery-date-on-sales-order-is-not-transferred-to-material-request-item-required-by-date/140479 fixing When you create a Material Request directly on the Sales Order via → Create → Material Request, Delivery Date on Sales Order Item is not transferred to Material Request Item Required By date. * fix(linters): meaningless linters formatting message applied In order to pass the linters test which I find meaningless as it asks for the comma after the last item in a dictionary data type * fix(linters): formatting code for linters pass Linters formatting applied (cherry picked from commit 42edb9f)
nabinhait
pushed a commit
that referenced
this pull request
Jan 24, 2025
…… (backport #45227) (#45424) fix(material request): mapping Sales Order Item Delivery Date to Mate… (#45227) * fix(material request): mapping Sales Order Item Delivery Date to Material Request Item Required By as mentioned in https://discuss.frappe.io/t/item-delivery-date-on-sales-order-is-not-transferred-to-material-request-item-required-by-date/140479 fixing When you create a Material Request directly on the Sales Order via → Create → Material Request, Delivery Date on Sales Order Item is not transferred to Material Request Item Required By date. * fix(linters): meaningless linters formatting message applied In order to pass the linters test which I find meaningless as it asks for the comma after the last item in a dictionary data type * fix(linters): formatting code for linters pass Linters formatting applied (cherry picked from commit 42edb9f) Co-authored-by: Tufan Kaynak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mentioned in https://discuss.frappe.io/t/item-delivery-date-on-sales-order-is-not-transferred-to-material-request-item-required-by-date/140479 fixing
When you create a Material Request directly on the Sales Order via → Create → Material Request, Delivery Date on Sales Order Item is not transferred to Material Request Item Required By date.