fix: Validate party on non receivable / payable account #44839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…frappe#44679) (cherry picked from commit 00898be)
* feat: Create subcontracted PO from Material Request * fix: Made minor changes in logic to pass all test cases * refactor: Made changes suggested by mentor and simplified logic * test: Made changes to tests
…it_voucher_balance
… no in gross profit report
* fix(ux): purchase invoice link in error message * chore: fix linter --------- Co-authored-by: ruthra kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Allows specifying a party type and party for non-receivable and non-payable accounts.
Fix: Validate the party type against the account type in the GL entry and display an error message if there's a mismatch.
Ref: 27331
Before:
before.party.type.validation.webm
After:
after.party.type.validation.webm
Backport needed for v14 & v15