fix: attribute order in create multiple variants dialog #44800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed attribute order in create multiple variant dialog.
ShreyasTheNewbie
changed the title
ShreyasTheNewbie
changed the title
Fixed attribute order in create multiple variant dialog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Item , Create > Multiple Variants dialog displays Attributes in Different Order each time
Before.mp4
Replaced this with
frm.doc.attributes.map(idx => idx.attribute)After.mp4
This pull request includes a change to the
erpnext/stock/doctype/item/item.jsfile. The modification improves the way attribute keys are handled when creating fields from attribute values.erpnext/stock/doctype/item/item.js: Changed the method of iterating over attribute keys by usingfrm.doc.attributes.map(idx => idx.attribute)instead ofObject.keys(attr_dict).