fix: Paid + Write Off Amount issue in Sales Invoice #44763
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishakhdesai
force-pushed
the
fix-si-issue
branch
from
daef362 to
1fd7ba7
Compare
ruthra-kumar
pushed a commit
that referenced
this pull request
Dec 24, 2024
…#44874) fix: Paid + Write Off Amount issue in Sales Invoice (cherry picked from commit 1fd7ba7) Co-authored-by: vishakhdesai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://support.frappe.io/helpdesk/tickets/26091
In the case of Return the validation
validate_posis comparing the amounts as negative amounts and when trying to make a partial return it throws the above error.Fix: Perform the comparision after taking their absolute value