Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove field precision in Sales and Purchase Order for percentage fields (backport #44376) #44383

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 27, 2024

Remove field precision for Sales Order and Purchase Order fields:

  • % Delivered
  • % Amount Billed
  • % Picked
  • % Received

This is to maintain consistency as precision is not used while setting Status on backend.

Undoing the changes made in: #44319
Replicating the changes made in: #43690 for sales_order_list.js


This is an automatic backport of pull request #44376 done by [Mergify](https://mergify.com).

(cherry picked from commit eff9cd1)

# Conflicts:
#	erpnext/selling/doctype/sales_order/sales_order_list.js
Copy link
Contributor Author

mergify bot commented Nov 27, 2024

Cherry-pick of eff9cd1 has failed:

On branch mergify/bp/version-15-hotfix/pr-44376
Your branch is up to date with 'origin/version-15-hotfix'.

You are currently cherry-picking commit eff9cd10cd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   erpnext/buying/doctype/purchase_order/purchase_order.js
	modified:   erpnext/selling/doctype/sales_order/sales_order.js

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/selling/doctype/sales_order/sales_order_list.js

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ruthra-kumar ruthra-kumar merged commit 632412b into version-15-hotfix Nov 27, 2024
5 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-15-hotfix/pr-44376 branch November 27, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants