Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup args structure akin to some typing #44226

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

blaggacao
Copy link
Collaborator

@blaggacao blaggacao commented Nov 19, 2024

this clarification is a human precondition to being able to investigate and fix #44219

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Nov 19, 2024
@blaggacao blaggacao enabled auto-merge (squash) November 19, 2024 17:26
@blaggacao blaggacao removed the needs-tests This PR needs automated unit-tests. label Nov 19, 2024
@blaggacao blaggacao force-pushed the refactor/cleanup-args-structure branch from 2d4a6ac to 223937c Compare November 19, 2024 18:19
@blaggacao blaggacao force-pushed the refactor/cleanup-args-structure branch 2 times, most recently from 9cadc8e to 76c7462 Compare November 19, 2024 20:15
@blaggacao
Copy link
Collaborator Author

blaggacao commented Nov 19, 2024

#44228 holds a generalization of the context normalizer pattern.

@blaggacao blaggacao enabled auto-merge (squash) November 19, 2024 20:18
@blaggacao blaggacao force-pushed the refactor/cleanup-args-structure branch from 76c7462 to 6848509 Compare November 19, 2024 20:57
@blaggacao blaggacao force-pushed the refactor/cleanup-args-structure branch 3 times, most recently from 6ae25ce to 6a2edf6 Compare November 19, 2024 21:51
@blaggacao blaggacao enabled auto-merge (squash) November 19, 2024 21:52
@blaggacao blaggacao force-pushed the refactor/cleanup-args-structure branch from 6a2edf6 to 0fe5a31 Compare November 19, 2024 21:54
@blaggacao blaggacao merged commit daabe84 into frappe:develop Nov 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Net amount calculated incorrectly
1 participant