Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: added progressive disclosure to assets #44187

Merged
merged 3 commits into from
Nov 27, 2024
Merged

style: added progressive disclosure to assets #44187

merged 3 commits into from
Nov 27, 2024

Conversation

khushi8112
Copy link
Member

@khushi8112 khushi8112 commented Nov 18, 2024 •
edited
Loading

Previous UI:

REC-20241118150628.mp4

Updated UI:

REC-20241120115848.mp4

@khushi8112 khushi8112 requested review from nabinhait and removed request for deepeshgarg007 November 18, 2024 09:48
nabinhait
nabinhait previously requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@nabinhait nabinhait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move depreciation-related things to a new tab?

@khushi8112 khushi8112 requested a review from nabinhait November 20, 2024 06:47
@khushi8112 khushi8112 enabled auto-merge November 25, 2024 19:35
barredterra
barredterra approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@barredterra barredterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@khushi8112 khushi8112 merged commit 9a5d68f into frappe:develop Nov 27, 2024
16 checks passed
@barredterra
Copy link
Collaborator

barredterra commented Nov 27, 2024 •
edited
Loading

@khushi8112 FYI, style: commits are usually used for code style, not for UI style. ;)

style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)

https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barredterra barredterra barredterra approved these changes

@nabinhait nabinhait Awaiting requested review from nabinhait

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khushi8112 @barredterra @nabinhait