Skip to content

Commit

Permalink
chore: Add translations to QI validations in Update stock_controller.py
Browse files Browse the repository at this point in the history
chore: Add translations to QI validations in Update stock_controller.py
  • Loading branch information
ernestoruiz89 authored Nov 23, 2024
1 parent e9ea9ee commit 6754f15
Showing 1 changed file with 15 additions and 9 deletions.
24 changes: 15 additions & 9 deletions erpnext/controllers/stock_controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -1008,11 +1008,13 @@ def validate_inspection(self):
def validate_qi_presence(self, row):
"""Check if QI is present on row level. Warn on save and stop on submit if missing."""
if not row.quality_inspection:
msg = f"Row #{row.idx}: Quality Inspection is required for Item {frappe.bold(row.item_code)}"
msg = _("Row #{0}: Quality Inspection is required for Item {1}").format(
row.idx, frappe.bold(row.item_code)
)
if self.docstatus == 1:
frappe.throw(_(msg), title=_("Inspection Required"), exc=QualityInspectionRequiredError)
frappe.throw(msg, title=_("Inspection Required"), exc=QualityInspectionRequiredError)
else:
frappe.msgprint(_(msg), title=_("Inspection Required"), indicator="blue")
frappe.msgprint(msg, title=_("Inspection Required"), indicator="blue")

def validate_qi_submission(self, row):
"""Check if QI is submitted on row level, during submission"""
Expand All @@ -1021,11 +1023,13 @@ def validate_qi_submission(self, row):

if qa_docstatus != 1:
link = frappe.utils.get_link_to_form("Quality Inspection", row.quality_inspection)
msg = f"Row #{row.idx}: Quality Inspection {link} is not submitted for the item: {row.item_code}"
msg = _("Row #{0}: Quality Inspection {1} is not submitted for the item: {2}").format(
row.idx, link, row.item_code
)
if action == "Stop":
frappe.throw(_(msg), title=_("Inspection Submission"), exc=QualityInspectionNotSubmittedError)
frappe.throw(msg, title=_("Inspection Submission"), exc=QualityInspectionNotSubmittedError)
else:
frappe.msgprint(_(msg), alert=True, indicator="orange")
frappe.msgprint(msg, alert=True, indicator="orange")

def validate_qi_rejection(self, row):
"""Check if QI is rejected on row level, during submission"""
Expand All @@ -1034,11 +1038,13 @@ def validate_qi_rejection(self, row):

if qa_status == "Rejected":
link = frappe.utils.get_link_to_form("Quality Inspection", row.quality_inspection)
msg = f"Row #{row.idx}: Quality Inspection {link} was rejected for item {row.item_code}"
msg = _("Row #{0}: Quality Inspection {1} was rejected for item {2}").format(
row.idx, link, row.item_code
)
if action == "Stop":
frappe.throw(_(msg), title=_("Inspection Rejected"), exc=QualityInspectionRejectedError)
frappe.throw(msg, title=_("Inspection Rejected"), exc=QualityInspectionRejectedError)
else:
frappe.msgprint(_(msg), alert=True, indicator="orange")
frappe.msgprint(msg, alert=True, indicator="orange")

def update_blanket_order(self):
blanket_orders = list(set([d.blanket_order for d in self.items if d.blanket_order]))
Expand Down

0 comments on commit 6754f15

Please sign in to comment.