-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix function clash for non-storage arguments #34
Conversation
TODO: retrieve UDVT underlying type
The issue was more general as only storage arguments were previously handled, which are converted to I've generalized the fix so that we get the "ABI type" of every argument, which in the case of UDVT is the underlying, and use types that have different ABI and source-level types to disambiguate. |
Co-authored-by: Hadrien Croubois <[email protected]>
Co-authored-by: Hadrien Croubois <[email protected]>
This is caused by
getFunctionId
not resolving the UDVT.Given the following solidity code:
getFunctionId
will returnunwrapUdvtConflict.myFirstType
unwrapUdvtConflict.mySecondType
The system doesn't see them as colliding, when in fact they do collide.