EncodeBuilder: Remove support of controls that should not be supported in JSON strings #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
===========================================
+ Coverage 99.96% 100.00% +0.03%
===========================================
Files 38 38
Lines 5323 5318 -5
===========================================
- Hits 5321 5318 -3
+ Misses 1 0 -1
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
… a JSON string According to the spec https://www.json.org/json-en.html these are the only valid controls \b Backspace (ascii code 08) \f Form feed (ascii code 0C) \n New line \r Carriage return \t Tab \" Double quote \\ Backslash character
marcsantiago
force-pushed
the
fix-encode-builder
branch
from
57a9204 to
dcc6f90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the JSON spec these are the only valid and considered controls for JSON
\b Backspace (ascii code 08)
\f Form feed (ascii code 0C)
\n New line
\r Carriage return
\t Tab
" Double quote
\ Backslash character
https://www.json.org/json-en.html
fixes #145