Fix performance: avoid silencing PHP error with @, use isset() instead

Regression since 11.8 in case of $ind_concat collision For example: '11' . '3' and '1' . '13'
francoisjacquet · Sep 1, 2024 · a7cbade · a7cbade
1 parent f80dbe1
commit a7cbade
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -4,6 +4,7 @@
 Changes in 11.8.3
 -----------------
 - Fix SQL error escape course title & save course, not course period title in FinalGrades.inc.php
+- Fix performance: avoid silencing PHP error with @, use isset() instead in DBGet.fnc.php
 
 Changes in 11.8.2
 -----------------

diff --git a/functions/DBGet.fnc.php b/functions/DBGet.fnc.php
@@ -88,7 +88,7 @@ function DBGet( $QI, $functions = [], $index = [] )
 				$ind[] = issetVal( $RET[ $col ] );
 			}
 
-			$ind_concat = implode( '', $ind );
+			$ind_concat = implode( '-', $ind );
 
 			$this_ind = isset( $s[ $ind_concat ] ) ? ++$s[ $ind_concat ] : ( $s[ $ind_concat ] = 1 );
 		}