feat: add onMissingSigner callback#538
Merged
stephancill merged 1 commit intofix/missing-onsigfrom Jan 28, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
normanzb
force-pushed
the
fix/missing-onsig
branch
from
8cc49fd to
0fa5f34
Compare
normanzb
force-pushed
the
feat/callback-signerless
branch
from
6d9409b to
29107bd
Compare
Contributor
Author
|
@michalkvasnicak do we want to add it into stable |
normanzb
force-pushed
the
fix/missing-onsig
branch
2 times, most recently
from
f048495 to
b4aa15d
Compare
normanzb
force-pushed
the
feat/callback-signerless
branch
from
29107bd to
462788a
Compare
michalkvasnicak
approved these changes
Jan 28, 2025
stephancill
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Previously in order to determine when the signer is missing but required by the button action, it requires the devs to add callback
onMissingIdentitytouseFarcasterMultiIdentityto determine such event, which is not very straight forward.(when signer is missing the hook calls into
frameStae.signerState.onSignerlessFramePress, which in turns triggersonMissingIdentitycallback on theuseFarcasterMultiIdentity)The PR adds a dedicated
onMissingSignercallback foruseFrame_unstable. The callback will be called when the button action requires a signer but signer is not found.@michalkvasnicak by looking at the code, it feels to me that adding
onTransactionButtonError/onPostButtonErrorcould be confusing, I am worrying the naming could give developers a false impression that all errors happened within transaction/post button action will be caught by the callbacks. (unless we change all errors within button action to also trigger the callbacks?). hence in this PR I renamed the callback name to be more specific.Merge Checklist