Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: frames v2 support #531

Draft
wants to merge 69 commits into
base: dev
Choose a base branch
from
Draft

feat: frames v2 support #531

wants to merge 69 commits into from

Conversation

michalkvasnicak
Copy link
Collaborator

@michalkvasnicak michalkvasnicak commented Nov 28, 2024

Change Summary

TODO

  • - add react-native-web-view support
  • - add test for farcaster v2 parser
  • - actions.setPrimaryButton is implemented but there is no way at the moment to send the primaryButtonClicked event back to iframe
  • - frames.json manifest validation
  • - create own comlink fork that will implement cleaning up of exposed listeners
  • - if debugger detects also valid v2 but the v1 is selected as protocol, show a hint to developer so they know they need to change to v2
  • - farcaster manifest tab in debugger
  • - add a functionality to generate JSON Farcaster Signatures to debugger.
  • - add fetch functionality to useFrameApp() hook so it doesn't depend on useFrame().
  • - add event emitters so we can emit changes on eth provider to frames app
  • - fix missing connector.emitter
  • - implement notifications
    • - simple notifications log
    • - manage adding / removing frame app from notifications panel
    • - manage enabling / disabling frame app notifications from the panel if app is added
    • - send events to app webhook
    • - log events sent to webhook and their respective responses
    • - sign events sent to app webhook
  • - add preview how frame is rendered in a feed (buttonTitle in manifest)
  • - add trigger config information to debugger (allow to open the app not only by pressing the frame button but also by running it based on trigger configuration - render as buttons below the frame)
  • - render frame app as part of the page (not in dialogue) and provide developer tools like event history, notification debugging
  • - integrate farcaster's code

Merge Checklist

  • PR has a Changeset
  • PR includes documentation if necessary
  • PR updates the boilerplates if necessary

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frames-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:51am
framesjs-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:51am
framesjs-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:51am

@r4topunk
Copy link

@michalkvasnicak does this pr add support for rendering v2 frames as well?

@michalkvasnicak
Copy link
Collaborator Author

@r4topunk yes it does.

@r4topunk
Copy link

@michalkvasnicak awesome, I will wait, thanks for responding so fast

@SamuelLHuber
Copy link
Contributor

love seeing this 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants