Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce manifest file for fast disk cache clear #780

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Oct 26, 2024

Signed-off-by: MrCroxx [email protected]## What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

Introduce manifest file for fast disk cache clear.

Changes:

  • Introduce manifest file to disk cache for fast disk cache clear.
  • Direct fs device can use default manifest file, direct file device must specify one.
  • Remove small object disk cache meta region, use manifest file instead.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

@MrCroxx MrCroxx added feature New feature or request refactor labels Oct 26, 2024
@MrCroxx MrCroxx added this to the v0.13 milestone Oct 26, 2024
@MrCroxx MrCroxx self-assigned this Oct 26, 2024
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 88.84298% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer/src/hybrid/builder.rs 0.00% 9 Missing ⚠️
foyer-storage/src/store.rs 57.89% 8 Missing ⚠️
foyer-storage/src/manifest.rs 97.81% 3 Missing ⚠️
foyer-storage/src/large/batch.rs 77.77% 2 Missing ⚠️
foyer-storage/src/small/set_manager.rs 81.81% 2 Missing ⚠️
foyer-bench/src/main.rs 66.66% 1 Missing ⚠️
foyer-storage/src/large/generic.rs 96.42% 1 Missing ⚠️
foyer-storage/src/small/generic.rs 87.50% 1 Missing ⚠️
Files with missing lines Coverage Δ
foyer-storage/src/device/direct_fs.rs 88.26% <100.00%> (+0.19%) ⬆️
foyer-storage/src/large/reclaimer.rs 86.25% <100.00%> (+0.77%) ⬆️
foyer-storage/src/large/recover.rs 89.60% <100.00%> (-0.70%) ⬇️
foyer-storage/src/region.rs 88.95% <ø> (-1.66%) ⬇️
foyer-storage/src/small/batch.rs 81.33% <100.00%> (ø)
foyer-bench/src/main.rs 65.05% <66.66%> (+<0.01%) ⬆️
foyer-storage/src/large/generic.rs 89.83% <96.42%> (+0.08%) ⬆️
foyer-storage/src/small/generic.rs 75.54% <87.50%> (+0.40%) ⬆️
foyer-storage/src/large/batch.rs 83.01% <77.77%> (-0.06%) ⬇️
foyer-storage/src/small/set_manager.rs 87.94% <81.81%> (-2.35%) ⬇️
... and 3 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactor
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant