Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpp: Fix incorrect exception being caught, fix docker warnings #796

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

achim-k
Copy link
Collaborator

@achim-k achim-k commented Jul 29, 2024

Changelog

Cpp: Fix incorrect exception being caught, fix docker warnings #796

Docs

None

Description

  • Fixes incorrect exception being caught (noticed that in foxglove/ros-foxglove-bridge@44abb8d)
  • Fix docker warnings (WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 24))
  • Bumps conan recipe version

@achim-k achim-k requested a review from jtbandes July 29, 2024 18:24
@achim-k achim-k changed the title Bump conan recipe version, fix incorrect exception being caught Cpp: Fix incorrect exception being caught, fix docker warnings Jul 29, 2024
@achim-k achim-k merged commit 58af014 into main Jul 30, 2024
8 checks passed
@achim-k achim-k deleted the achim/update-cpp branch July 30, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants