Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PyPI publishing #158

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Fix PyPI publishing #158

merged 1 commit into from
Dec 11, 2024

Conversation

jtbandes
Copy link
Member

Running a publish to TestPyPI immediately followed by a publish to the "real" PyPI triggered an error due to a file already existing. The workaround recommended in pypa/gh-action-pypi-publish#283 (comment) is to set attestations: false on the TestPyPI publish.

indirectlylit
indirectlylit approved these changes Dec 11, 2024
View reviewed changes
Copy link

@indirectlylit indirectlylit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading through the linked thread, this seems fine to me because we're only disabling on the test jobs.

(it does sound like the recommended fix is to split test and prod into separate flows, but this workaround seems reasonable)

@jtbandes jtbandes merged commit 47468f9 into main Dec 11, 2024
8 checks passed
@jtbandes jtbandes deleted the jacob/fix-pypi branch December 11, 2024 23:59
@jtbandes jtbandes mentioned this pull request Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indirectlylit indirectlylit indirectlylit approved these changes

@achim-k achim-k Awaiting requested review from achim-k

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtbandes @indirectlylit