Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating distortion model description #139

Merged
merged 14 commits into from
Jan 12, 2024
2 changes: 1 addition & 1 deletion internal/schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@ const CameraCalibration: FoxgloveMessageSchema = {
name: "distortion_model",
type: { type: "primitive", name: "string" },
description:
"Name of distortion model\n\nSupported values: `plumb_bob` and `rational_polynomial`",
"Name of distortion model\n\nFoxglvoe supports `plumb_bob` (k1, k2, p1, p2, k3) and `rational_polynomial`(k1, k2, p1, p2, k3, k4, k5, k6) distortion based on [OpenCV's implementation](https://docs.opencv.org/2.4/modules/calib3d/doc/camera_calibration_and_3d_reconstruction.html) of the [Brown-Conrady pinhole camera model](https://en.wikipedia.org/wiki/Distortion_%28optics%29#Software_correction). This is the same [implementation used in ROS](http://docs.ros.org/en/diamondback/api/image_geometry/html/c++/pinhole__camera__model_8cpp_source.html)",
banisadr marked this conversation as resolved.
Show resolved Hide resolved
},
{
name: "D",
Expand Down
Loading