Skip to content

Commit

Permalink
Update RawImage schema with endianness (#153)
Browse files Browse the repository at this point in the history
### Changelog
<!-- Write a one-sentence summary of the user-impacting change (API,
UI/UX, performance, etc) that could appear in a changelog. Write "None"
if there is no user-facing change -->
 - specify that `16UC1` and `32FC1` are interpreted as little endian

### Docs

<!-- Link to a Docs PR, tracking ticket in Linear, OR write "None" if no
documentation changes are needed. -->

### Description

Specify that `16UC1` and `32FC1` are interpreted as little endian

<!-- Describe the problem, what has changed, and motivation behind those
changes. Pretend you are advocating for this change and the reader is
skeptical. -->

<!-- In addition to unit tests, describe any manual testing you did to
validate this change. -->

<table><tr><th>Before</th><th>After</th></tr><tr><td>

<!--before content goes here-->

</td><td>

<!--after content goes here-->

</td></tr></table>

<!-- If necessary, link relevant Linear or Github issues. Use `Fixes:
foxglove/repo#1234` to auto-close the Github issue or Fixes: FG-### for
Linear isses. -->

FG-8171
  • Loading branch information
snosenzo authored Jul 22, 2024
1 parent 446d4f0 commit a95e4e0
Show file tree
Hide file tree
Showing 13 changed files with 13 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,7 @@ export type RawImage = {
/**
* Encoding of the raw image data
*
* Supported values: \`8UC1\`, \`8UC3\`, \`16UC1\`, \`32FC1\`, \`bayer_bggr8\`, \`bayer_gbrg8\`, \`bayer_grbg8\`, \`bayer_rggb8\`, \`bgr8\`, \`bgra8\`, \`mono8\`, \`mono16\`, \`rgb8\`, \`rgba8\`, \`uyvy\` or \`yuv422\`, \`yuyv\` or \`yuv422_yuy2\`
* Supported values: \`8UC1\`, \`8UC3\`, \`16UC1\` (little endian), \`32FC1\` (little endian), \`bayer_bggr8\`, \`bayer_gbrg8\`, \`bayer_grbg8\`, \`bayer_rggb8\`, \`bgr8\`, \`bgra8\`, \`mono8\`, \`mono16\`, \`rgb8\`, \`rgba8\`, \`uyvy\` or \`yuv422\`, \`yuyv\` or \`yuv422_yuy2\`
*/
encoding: string;
Expand Down
2 changes: 1 addition & 1 deletion internal/schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,7 @@ const RawImage: FoxgloveMessageSchema = {
name: "encoding",
type: { type: "primitive", name: "string" },
description:
"Encoding of the raw image data\n\nSupported values: `8UC1`, `8UC3`, `16UC1`, `32FC1`, `bayer_bggr8`, `bayer_gbrg8`, `bayer_grbg8`, `bayer_rggb8`, `bgr8`, `bgra8`, `mono8`, `mono16`, `rgb8`, `rgba8`, `uyvy` or `yuv422`, `yuyv` or `yuv422_yuy2`",
"Encoding of the raw image data\n\nSupported values: `8UC1`, `8UC3`, `16UC1` (little endian), `32FC1` (little endian), `bayer_bggr8`, `bayer_gbrg8`, `bayer_grbg8`, `bayer_rggb8`, `bgr8`, `bgra8`, `mono8`, `mono16`, `rgb8`, `rgba8`, `uyvy` or `yuv422`, `yuyv` or `yuv422_yuy2`",
},
{
name: "step",
Expand Down
2 changes: 1 addition & 1 deletion ros_foxglove_msgs/ros1/RawImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ros_foxglove_msgs/ros2/RawImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion schemas/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion schemas/flatbuffer/RawImage.fbs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion schemas/jsonschema/RawImage.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion schemas/jsonschema/index.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion schemas/omgidl/foxglove/RawImage.idl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion schemas/proto/foxglove/RawImage.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion schemas/ros1/RawImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion schemas/ros2/RawImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion schemas/typescript/RawImage.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a95e4e0

Please sign in to comment.