Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also advertise channels for ROS1 topics without publishers #341

Conversation

achim-k
Copy link
Collaborator

@achim-k achim-k commented Feb 21, 2025

Changelog

ROS1 topics that have no publishers (only subscribers) are now also advertised

Docs

None

Description

See https://github.com/orgs/foxglove/discussions/1085 for context.

Uses the getTopicTypes method of the ROS master API to request available topics. In contrast to getPublishedTopics, which is the method called under by ros::master::getTopics, the getTopicTypes method returns all topics, also the ones that are not published but only subscribed.

Copy link

linear bot commented Feb 21, 2025

@achim-k achim-k requested a review from jtbandes February 21, 2025 20:52
@achim-k achim-k merged commit bf15e25 into main Feb 21, 2025
9 checks passed
@achim-k achim-k deleted the achim/fg-10578-foxglove-bridge-does-not-advertise-topics-without-publishers branch February 21, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants