FG-2933: Add recorder support for audio frames to MCAP recording demo #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgwt202412
force-pushed
the
fgwt202412/audio-recorder
branch
from
02b405a to
5661220
Compare
fgwt202412
force-pushed
the
fgwt202412/audio-recorder
branch
from
36f7053 to
32a35ac
Compare
fgwt202412
commented
Dec 15, 2024
fgwt202412
commented
Dec 15, 2024
website/package.json
Outdated
| @@ -22,7 +22,7 @@ | |||
| "@docusaurus/preset-classic": "2.4.1", | |||
| "@foxglove/eslint-plugin": "1.0.1", | |||
| "@foxglove/rostime": "1.1.2", | |||
| "@foxglove/schemas": "1.6.2", | |||
| "@foxglove/schemas": "github:foxglove/schemas#4cd9d40f61a46ec6a209e0c0f5d85db3cc9e6488", | |||
There was a problem hiding this comment.
After foxglove/schemas#159 has been submitted and before merging this PR, update the version here and yarn install to update the yarn.lock.
Suggested change
| "@foxglove/schemas": "github:foxglove/schemas#4cd9d40f61a46ec6a209e0c0f5d85db3cc9e6488", | |
| "@foxglove/schemas": "1.6.7", |
fgwt202412
force-pushed
the
fgwt202412/audio-recorder
branch
from
6fcd2d3 to
cedca32
Compare
fgwt202412
force-pushed
the
fgwt202412/audio-recorder
branch
from
cedca32 to
742d8f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
None
Docs
None
Description
Foxglove does not currently support audio messages of any kind. In order to support playback of audio in Foxglove Studio, this stack of PRs adds support to record MCAP files with audio.
In this first PR, I add the ability to record audio data to the MCAP demo recorder. This does not include the user-facing controls to actually record the audio - just the plumbing to write the messages to the MCAP file.
Tested locally using the MCAP recording demo and a new Audio panel.
FG-2933