Skip to content

Add key to pending imports #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryfox merged 3 commits into from
Oct 7, 2025
Merged

Add key to pending imports #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48f008c
Add key to pending imports
cmansley Oct 6, 2025
1de8e75
Fix spacing
cmansley Oct 6, 2025
6879e3c
Fix spacing again
cmansley Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions foxglove/api/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,7 @@ func (e ExtensionResponse) String() string {

type PendingImportsRequest struct {
RequestId string `json:"requestId" form:"requestId,omitempty"`
Key string `json:"key" form:"key,omitempty"`
DeviceId string `json:"device.id" form:"device.id,omitempty"`
DeviceName string `json:"device.name" form:"device.name,omitempty"`
Error string `json:"error" form:"error,omitempty"`
Expand Down
3 changes: 3 additions & 0 deletions foxglove/cmd/pending_imports.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
func newPendingImportsCommand(params *baseParams) *cobra.Command {
var format string
var requestId string
var key string
var deviceId string
var deviceName string
var filename string
Expand Down Expand Up @@ -46,6 +47,7 @@ func newPendingImportsCommand(params *baseParams) *cobra.Command {
os.Stdout,
api.PendingImportsRequest{
RequestId: requestId,
Key: key,
DeviceId: deviceId,
DeviceName: deviceName,
Error: error,
Expand All @@ -70,6 +72,7 @@ func newPendingImportsCommand(params *baseParams) *cobra.Command {
pendingImportsCmd.PersistentFlags().StringVarP(&projectID, "project-id", "", viper.GetString("default_project_id"), "Project ID")
pendingImportsCmd.PersistentFlags().BoolVarP(&withoutProject, "without-project", "", false, "Filter to pending imports without a project")
pendingImportsCmd.PersistentFlags().StringVarP(&requestId, "request-id", "", "", "Request ID")
pendingImportsCmd.PersistentFlags().StringVarP(&key, "key", "", "", "Key")
pendingImportsCmd.PersistentFlags().StringVarP(&deviceId, "device-id", "", "", "Device ID")
pendingImportsCmd.PersistentFlags().StringVarP(&deviceName, "device-name", "", "", "Device name")
pendingImportsCmd.PersistentFlags().StringVarP(&filename, "filename", "", "", "Filename")
Expand Down
Loading